Ethereal-dev: [ethereal-dev] Checked in Wiretap changes to eliminate "ftell()" calls

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <gharris@xxxxxxxxxxxx>
Date: Fri, 27 Aug 1999 18:32:19 -0700
"lseek()", called from "ftell()", showed up on some profiling runs I did
on Solaris 2.5/SPARC, so I checked in some changes to Wiretap to have it
maintain the current offset into the file itself, rather than calling
"ftell()" just before reading the data for each packet.  (It's not as
significant on FreeBSD as I remember it being on Solaris, but it still
shows up.)

I tried several different types of capture files, and it seemed to work,
but I may have broken the code to read some capture files; let me know
if some files can't be read with the new code but can be read with the
old code.  (No "mmap()" yet - that's a bigger change.)