Ethereal-dev: [ethereal-dev] Re: RSVP is broken in Ethereal 0.7.x

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Gilbert Ramirez <gram@xxxxxxxxxx>
Date: Thu, 26 Aug 1999 21:07:06 -0500
On Thu, Aug 26, 1999 at 08:47:57PM -0500, Ashok Narayanan wrote:
> 
> Here is some more new stuff for RSVP. I implemented the display
> filtering parts and it works very well. Kudos on a good filtering
> architecture. I've attached new versions of packet-rsvp.c and
> packet-rsvp.h.

Thanks. I received the attachments in the e-mail that you sent to me
after his e-mail.

> Couple of comments. Firstly, I defined a bunch of hidden flags which
> are just boolean flags indicating whether the message is a Path, Resv
> etc. (rsvp.path indicates that it is a Path). Should we add a
> FT_BOOLEAN type just for clarity & documentation purposes. It wouldn't
> really be a big change.

Poor documentation on my part! doc/proto_tree doesn't mention it,
but FT_BOOLEAN exists. (see proto.h). That's my fault for not keeping
the docs up to date. The scanner recognizes 'true' and 'false' as
the values. Token-Ring source routing is a boolean:

tr.sr == true

--gilbert